As a terrible singer will the fact that I am learning a musical instrument make me sing better?
Singing
# 1
# 2
Me too. What I have learned, though, is practice makes for better singing.
Guitar practice has made me better at hitting the vocal notes, IMO. I seem to hear and anticipate notes much better since I returned to guitar, e.g., when joining in with the car radio I often nail it and sound good (again, IMO 
). I've also noticed that repeated practice with any song makes not only my guitar playing better but makes my voice stronger and more on pitch too.
"It takes a lot of devotion and work, or maybe I should say play, because if you love it, that's what it amounts to. I haven't found any shortcuts, and I've been looking for a long time."
-- Chet Atkins
-- Chet Atkins
# 3
Ear training is a good way to improve singing as well. Practising to learn to recognise intervals, scales and chords by ear by singing different intervals, scales (major, natural - harmonic - melodic minor, pentatonic..) and chord arrpeggios will make you a better singer.
# 4
# 5
