If you write a song or riff that sounds good after hearing it 100 times and that others tell you are good then you know you have something. I always look for that magic riff that the universe hides. Isn't it funny how the best riffs seem to write themselves, like just jump out of the guitar or your hands. Whenever I try to apply too much theory or scale patterns I feel dissapointed.