For rock/pop, most famous bands and "singers" don't actually have very good singing voices... their voices are not very smooth and they often have poor tone and pitch control... but what they do have is character. Look at Bob Dylan or Neil Young for extreme examples...