Ok so I started playing guitar when i was about 15 years old (24 now). I usually just dicked around and played blackmetal which didnt need to be super acurrate. Now I am getting into acoustic and learning how to sing, I want to do the singer/songwriter thing.

Problem is, I realized that over the years i've learned a lot of bad habits and my "foundation" of playing is really sloppy and weak, especially rhythm wise. I'm just learning how to sing really, I just signed up for lessons so im looking forward to that.

But would it be wise, to stop writing songs and go back to the basics? I feel like prior this my practice is getting NOWHERE. Just a few days ago though, I started playing chords with a metronome just simple patterns.

Anyone have advice how to tackle my goals? Should I start playing simple patterns with a metronome to fix my rhythm and learn to sing as well with my teacher on a different level? Then once those two are solid then begin trying to combine them together?

I feel like im a good player and I understand music its just my technical skills have a bad foundation. Any advice is appreciated. Especially with effective practice. A lot of my practice turns into just long jam sessions where I get no real improvement from. Thanks!