Thanks - i know we're just changing the note name - on a guitar you would still play the same shapes - on a piano if all the black notes were sharps - there would be a black key between all the white keys.

I think I heard somewhere that Bach worked out the chromatic scale ?